flatironinstitute / ftk

Factorization of the translation kernel for fast rigid image alignment
Apache License 2.0
3 stars 1 forks source link

finufftpy deprecated #4

Open garrettwrong opened 2 years ago

garrettwrong commented 2 years ago

Joakim, we have a user here who was trying to install FTK and brought to my attention he couldn't find the old finufftpy package. I'm not sure he is prepared to install the older software from sources to reproduce the run.

How do you feel about finufftpy getting update to the newer finufft package?

ahbarnett commented 2 years ago

Dear Garrett & Joakim, You will see I attempted to edit FTK to use the new FINUFFT v2 py interfaces on a branch here:

https://github.com/flatironinstitute/ftk/tree/fiv2

Here's my commit: https://github.com/flatironinstitute/ftk/commit/570325b4028d3311eeafb3cfa47a491da7c315a0

However, the 4d indexing was a bit complicated and I was unable to run tests properly. I'd appreciate if Joakim could check it over. But the point is we're not starting from scratch here. Best, Alex

On Mon, Nov 29, 2021 at 11:51 AM Garrett Wright @.***> wrote:

Joakim, we have a user here who was trying to install FTK and brought to my attention he couldn't find the old finufftpy package. I'm not sure he is prepared to install the older software from sources to reproduce the run.

How do you feel about finufftpy getting update to the newer finufft package?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/flatironinstitute/ftk/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNZRSVCN4FOG2Y6B3L2BZDUOOVRJANCNFSM5I7TJNAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- *---------------------------------------------------------------------~^`^~._.~' |\ Alex H. Barnett Center for Computational Mathematics, Flatiron Institute | \ http://users.flatironinstitute.org/~ahb 646-876-5942

garrettwrong commented 2 years ago

Oh my, I missed the PR you had open, that's embarrassing. Thanks Alex. I'll try to chat with Joakim about it during our next ASPIRE meeting. Since I opened the issue I got a request to integrate this implementation...