search

flatironinstitute / ironclust

Spike sorting software being developed at Flatiron Institute, based on JRCLUST (Janelia Rocket Cluster)
Apache License 2.0
28 stars 7 forks source link

uimenu error #3

Closed zsperry closed 5 years ago

zsperry commented 5 years ago

Some of the calls to uimenu in irc.m refer to a 'Text' property that should be a 'Label.' Fixed locally, but probably want to fix here too. Thanks for the updates!

-Zach

jamesjun commented 5 years ago

Thanks. What version of Matlab are you using? I should make it version neutral.

-James

On Nov 19, 2018, at 10:28 AM, zsperry notifications@github.com wrote:

Some of the calls to uimenu in irc.m refer to a 'Text' property that should be a 'Label.' Fixed locally, but probably want to fix here too. Thanks for the updates!

-Zach

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

zsperry commented 5 years ago

2017a at the moment, though I just realized that...you had it as 'Label' some places but not all...weird they would change that by version, but I looked it up and you're right...

-Z

On Mon, Nov 19, 2018 at 10:31 AM James Jun notifications@github.com wrote:

Thanks. What version of Matlab are you using? I should make it version neutral.

-James

On Nov 19, 2018, at 10:28 AM, zsperry notifications@github.com wrote:

Some of the calls to uimenu in irc.m refer to a 'Text' property that should be a 'Label.' Fixed locally, but probably want to fix here too. Thanks for the updates!

-Zach

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jamesjun/ironclust/issues/3#issuecomment-439932876, or mute the thread https://github.com/notifications/unsubscribe-auth/AVNxB_RVgMjsmeIgdmYd4Ucq292I40_Oks5uws6sgaJpZM4YpVdF .

jamesjun commented 5 years ago

I wrote uimenu_() in irc.m which uses the appropriate field names depending on the Matlab version. matlab_version_() function returns the Matlab version installed on your system (2017.5 is returned if R2017b is installed and 2017 is returned if R2017 is installed).

zsperry commented 5 years ago

Thanks!

On Sun, Nov 25, 2018 at 4:37 PM James Jun notifications@github.com wrote:

Closed #3 https://github.com/jamesjun/ironclust/issues/3.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jamesjun/ironclust/issues/3#event-1985563156, or mute the thread https://github.com/notifications/unsubscribe-auth/AVNxBwd71IblxAH8gsMkUiPw3uFlyTolks5uyw2sgaJpZM4YpVdF .