flatironinstitute / ironclust

Spike sorting software being developed at Flatiron Institute, based on JRCLUST (Janelia Rocket Cluster)
Apache License 2.0
28 stars 7 forks source link

JRCLUST export #46

Open WeissShahaf opened 4 years ago

WeissShahaf commented 4 years ago

I tried to follow your instruction: Export to JRCLUST for manual curation. You need to clone JRCLUST and set the path path_jrclust in user.cfg. irc2 export-jrclust [path_to_prm_file]

-I could not find user.cfg anywhere, but i changed the JRCLUST path in default.cfg.

-Apparently the probe file it's looking for is a CSV, but none is created if using a .bin file. but even when supplying a CSV, i get multiple fail to copy messages

Copy failed: E:\ironclust\matlab\jrclust_patch//export_jrclust.m to ....\JRCLUST+jrclust+import\irc.m Copy failed: E:\ironclust\matlab\jrclust_patch//neCell2mat.m to ....\JRCLUST+jrclust+utils\neCell2mat.m Copy failed: E:\ironclust\matlab\jrclust_patch//processArgs.m to ....\JRCLUST\@JRC\processArgs.m Copy failed: E:\ironclust\matlab\jrclust_patch//loadProbe.m to ....\JRCLUST+jrclust\@Config\private\loadProbe.m

can you try to take a look at an example of our data and see if you can get it to run in irc2? and exported to jrclust?

https://www.dropbox.com/preview/test/test/GL383_20190822_OF_ExtraWall_g0_t0.imec0.ap.bin?role=personal

https://www.dropbox.com/preview/test/test/GL383_20190822_OF_ExtraWall_g0_t0.imec0.ap.meta?role=personal

jamesjun commented 4 years ago

Thanks. I only tested it on our .mda format but I should tests it on SpikeGLX format. IronClust GUI should be done this week.

-James

On Feb 13, 2020, at 7:45 AM, WeissShahaf notifications@github.com wrote:

 I tried to follow your instruction: Export to JRCLUST for manual curation. You need to clone JRCLUST and set the path path_jrclust in user.cfg. irc2 export-jrclust [path_to_prm_file]

-I could not find user.cfg anywhere, but i changed the JRCLUST path in default.cfg.

-Apparently the probe file it's looking for is a CSV, but none is created if using a .bin file. but even when supplying a CSV, i get multiple fail to copy messages

Copy failed: E:\ironclust\matlab\jrclust_patch//export_jrclust.m to ....\JRCLUST+jrclust+import\irc.m Copy failed: E:\ironclust\matlab\jrclust_patch//neCell2mat.m to ....\JRCLUST+jrclust+utils\neCell2mat.m Copy failed: E:\ironclust\matlab\jrclust_patch//processArgs.m to ....\JRCLUST@JRC\processArgs.m Copy failed: E:\ironclust\matlab\jrclust_patch//loadProbe.m to ....\JRCLUST+jrclust@Config\private\loadProbe.m

can you try to take a look at an example of our data and see if you can get it to run in irc2? and exported to jrclust?

https://www.dropbox.com/preview/test/test/GL383_20190822_OF_ExtraWall_g0_t0.imec0.ap.bin?role=personal

https://www.dropbox.com/preview/test/test/GL383_20190822_OF_ExtraWall_g0_t0.imec0.ap.meta?role=personal

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

WeissShahaf commented 4 years ago

one more thing, for the imec3_opt3.prb that is the default now for neuropixels probes is not right. i guess it fits the phase3a probes.

but the commercial P3B2 / 1.0 probes are different. with only 3 reference sites.

i'm attaching the file i'm using, given to me by Jennifer Colonell over at spikeGLX imec3b_staggered.zip

jamesjun commented 4 years ago

Wonderful, thanks for sharing the latest mapping file. I will add it to the probe file library.

-James

On Thu, Feb 13, 2020 at 12:22 PM WeissShahaf notifications@github.com wrote:

one more thing, for the imec3_opt3.prb that is the default now for neuropixels probes is not right. i guess it fits the phase3a probes.

but the commercial P3B2 / 1.0 probes are different. with only 3 reference sites.

i'm attaching the file i'm using, given to me by Jennifer Colonell over at spikeGLX imec3b_staggered.zip https://github.com/flatironinstitute/ironclust/files/4199848/imec3b_staggered.zip

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flatironinstitute/ironclust/issues/46?email_source=notifications&email_token=ACEHBOBVYKFMIFKLUOXFNHTRCV6WBA5CNFSM4KURYEDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELV3IMI#issuecomment-585872433, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEHBOH3U74KWYIJEI22YY3RCV6WBANCNFSM4KURYEDA .

jamesjun commented 4 years ago

I cannot download your files on Dropbox. Could you please create a sharable link and send it to me?

jamesjun commented 4 years ago

Dear Weiss, I have some questions about the probe file you made (imec3b_staggered.zip). There are three internal references and I expected you to exclude three sites but you excluded only one.

The phase 3A probe had 12 internal references and these channels do not contain neural recordings. Does probe 3B2 contain any useful recordings if the sites are not selected as internal references? The meta file you shared with me suggests that they were connected to external references.

WeissShahaf commented 4 years ago

i sent a new link by email.

On Fri, Feb 14, 2020 at 9:54 PM James Jun notifications@github.com wrote:

I cannot download your files on Dropbox. Could you please create a sharable link and send it to me?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flatironinstitute/ironclust/issues/46?email_source=notifications&email_token=AK4J42EIIWSA22IFLY5KFWDRC4AGXA5CNFSM4KURYEDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL2MZWQ#issuecomment-586468570, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4J42AJGDZX5TH52OTZOLLRC4AGXANCNFSM4KURYEDA .

--

Shahaf Weiss, PhD Max Planck Institute for Brain Research NSK - Laurent department, room 1.120 Max-von-Laue-Straße. 4 60438 Frankfurt am Main, Germany www.brain.mpg.de https://email.gwdg.de/owa/redir.aspx?C=7VzwRsdzDhtbiu7Ahx29IRVoe1iNWVvSOlu_TVQfe5hwnyOM8RrVCA..&URL=http%3a%2f%2fwww.brain.mpg.de

(work) shahaf.weiss@brain.mpg.de (personal) shahaf.me@gmail.com Tel:+49 17657814689

WeissShahaf commented 4 years ago

there are 3 ref sites, i think one in each site bank. plus the tip reference. they cannot be used for recording.

i'm not sure why but the internal sites work in about 50% of the probes, and are noisy in others.

alternatively, you can use an external reference wire, which we use for both ground and ref when possible, for a good LFP signal. however internal sites, especially the tip site are good for removing movement artifacts in-vivo.

On Fri, Feb 14, 2020 at 11:23 PM James Jun notifications@github.com wrote:

Dear Weiss, I have some questions about the probe file you made (imec3b_staggered.zip). There are three internal references and I expected you to exclude three sites but you excluded only one.

The phase 3A probe had 12 internal references and these channels do not contain neural recordings. Does probe 3B2 contain any useful recordings if the sites are not selected as internal references? The meta file you shared with me suggests that they were connected to external references.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flatironinstitute/ironclust/issues/46?email_source=notifications&email_token=AK4J42CH66D6LREWPINCJPTRC4KXNA5CNFSM4KURYEDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL2UMYA#issuecomment-586499680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4J42HO7EQD77Z2IQAS53DRC4KXNANCNFSM4KURYEDA .

--

Shahaf Weiss, PhD Max Planck Institute for Brain Research NSK - Laurent department, room 1.120 Max-von-Laue-Straße. 4 60438 Frankfurt am Main, Germany www.brain.mpg.de https://email.gwdg.de/owa/redir.aspx?C=7VzwRsdzDhtbiu7Ahx29IRVoe1iNWVvSOlu_TVQfe5hwnyOM8RrVCA..&URL=http%3a%2f%2fwww.brain.mpg.de

(work) shahaf.weiss@brain.mpg.de (personal) shahaf.me@gmail.com Tel:+49 17657814689

jamesjun commented 4 years ago

Thanks for letting me know. I added the bottom reference site back to the exclusion list.

-James

On Feb 18, 2020, at 4:12 AM, WeissShahaf notifications@github.com wrote:

 quick note: I see in the last commit you removed the ref site 192, from the imec3B2.prb, it is actually removed for the default setting (bottom 384 channels) because it cannot be used for recording. same for sites 576, 960 if using other channel configurations that are within that site range

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jamesjun commented 4 years ago

I still haven't tested JRCLUST export tool on your dataset but will get to it this week.