flatironinstitute / ironclust

Spike sorting software being developed at Flatiron Institute, based on JRCLUST (Janelia Rocket Cluster)
Apache License 2.0
28 stars 7 forks source link

Function meanSubt_ is defined twice #57

Closed chyumin closed 2 years ago

chyumin commented 2 years ago

I'm trying to compile ironclust to use as standalone application. But I'm getting the following error:

Error using compiler.internal.build.builder.Generic/build (line 81)
Error while determining required deployable files. Compilation terminated. Details:
Error using parseFile (line 13)

MATLAB code '/ironclust/matlab/irc2klusters.m' contains the following syntax error(s):
Line 513 column 22 : The current use of 'meanSubt_' is inconsistent with its previous use or definition (line 501).

Error in compiler.build.standaloneApplication (line 119)
resultsobj = builder.build;

The function meanSubt_ is currently defined in line 501 and line 513, which one is the correct to use?

bendichter commented 2 years ago

@magland

magland commented 2 years ago

I am not familiar with how this code works. However, I would venture a guess that the second definition is what you want, because in settings where you don't get a syntax error, I believe the second would override the first.

chyumin commented 2 years ago

I removed the first definition and it seems to be working fine.

Thank you

bendichter commented 2 years ago

@chyumin great! Could you please open a draft PR with your changes so we can keep track of what adjustments you needed to make?

chyumin commented 2 years ago

Done! @bendichter @magland