installation: update readme and tweak dependencies

flatironinstitute / jax-finufft

JAX bindings to the Flatiron Institute Non-uniform Fast Fourier Transform (FINUFFT) library

Apache License 2.0

77 stars 2 forks source link

installation: update readme and tweak dependencies #70

Closed lgarrison closed 6 months ago

lgarrison commented 6 months ago

Removing a confusing link in the documentation per #64. Also cleaning up some unnecessary(?) references to scipy and jaxlib, adding a missing numpy dep, and adding more info on JAX installation.

lgarrison commented 6 months ago

In the spirit of making the installation easier to debug, I also changed JAX_FINUFFT_USE_CUDA=ON to fail if CUDA is not found, instead of proceeding with a CPU installation with a warning. Otherwise, it's easy for a broken CUDA installation to cause the GPU extensions to not be built, resulting in confusing "MLIR translation rule for primitive ... not found for platform cuda" messages later.

dfm commented 6 months ago

LGTM - thank you!!