flatironinstitute / mcmc-monitor

Monitor MCMC runs in the browser
Other
36 stars 0 forks source link

Server should receive and respond to client protocol versions #27

Open jsoules opened 1 year ago

jsoules commented 1 year ago

There is a client-side check (in SetupMCMCMonitor.tsx) to confirm whether the requested service is running a protocol version that matches the client's. However, the client's protocol version does not appear to be part of the request sent to the server, and I can't find anywhere the server is checking that the client is compatible.

While in many cases the server won't have a relevant response for a mismatched client protocol version--we certainly don't want to make an open-ended promise about backward compatibility for prior protocol versions--it could be useful for the service to issue a console warning if it starts receiving requests for newer protocol versions than the one it supports, as this is a sign the service needs to be upgraded.