search

flatironinstitute / mcmc-monitor

Monitor MCMC runs in the browser
Other
36 stars 0 forks source link

Add repo link. Slight reorg of MainWindow code. #35

Closed jsoules closed 1 year ago

jsoules commented 1 year ago

Fix #33.

This mainly just adds the footer with the Github link to the "error connection" and "home" pages, but I also did a little light reorganization of the MainWindow.tsx to reduce some redundancy and break its components out a little bit more.

magland commented 1 year ago

Everything here looks good to me.

I noticed you removed the div with margin

<div style={{margin: 60}}>

I wonder if that will cause some display problems (content too close to edge)

jsoules commented 1 year ago

Shouldn't be removed--I just moved it into the LogoFrame component (which now applies to both Home.tsx and the connection error component so that those can share code).