search

flatironinstitute / mcmc-monitor

Monitor MCMC runs in the browser
Other
35 stars 0 forks source link

Code reorg #43

Closed jsoules closed 1 year ago

jsoules commented 1 year ago

This should just be moving things around. I've confirmed it still works as expected by clicking through all the tabs when connected to a local service and to the example data.

See dev deployment at https://flatironinstitute.github.io/mcmc-monitor/dev/ (or can try https://flatironinstitute.github.io/mcmc-monitor/dev?s=https://mcmc-monitor-proxy.herokuapp.com/s/5e088817c361db5a2a98&webrtc=1 for web-rtc connection to my currently running server)

Probably the best way to review is to look at the directory structure in the branch and see if it makes sense--the line edits are all to import paths.

magland commented 1 year ago

This all looks good, except I wonder about useMCMCMonitor.ts being in utils/. This seems like a pretty core functionality, not a utility (such as useWindowDimensions.ts)

jsoules commented 1 year ago

Yeah, that's a good point. But it does somehow feel like it should go somewhere other than the root. Maybe in MCMCMonitorDataManager with the rest of the client-side business-logic stuff?