search

flatironinstitute / mcmc-monitor

Monitor MCMC runs in the browser
Other
36 stars 0 forks source link

Fallback to http when no webrtc connection #54

Closed magland closed 1 year ago

magland commented 1 year ago

I have found that webrtc does not always work. In rtcshare, even though using a TURN server helps, it does not seem to solve the problem in all cases. I think it is most important that the system works and the page loads than insisting on using webrtc, even if it means some demand on our heroku proxy server. We have 2TB per month bandwidth, so that should be good for now, I believe. We can work on solving this problem down the road.

@jsoules what do you think?

Note: #53 should be merged first.

jsoules commented 1 year ago

I have no objections to making this change (though we should merge #53 and then rebase this off the new main to minimize the diffs). We can see about revisiting it later if bandwidth becomes a problem.

We do have test coverage for this function, so we should revise the tests to reflect the new intended behavior. (I can take care of this if you like--up to you.)