Pretty minor--I've deferred more thoroughgoing revisions to any components until after we've got tests lined up for them. I did add in-file-global variables to track the maximum number of items for the different categories of display grid, which were currently appearing as raw constants in several different locations.
Tested locally to confirm the layout looks as expected. During testing, I realized that the variable-selection-truncation notice for the 2D Matrix view was not being displayed. Turns out it is actually on the page, just the CSS for the matrix grid winds up covering it up. Fully diagnosing that and fixing it at the root would probably involve tweaks to several different components, which I'm not prepared to do at this point, so I just added a div for this specific case that has a bit more padding so the notice isn't obscured.
magland
commented
1 year ago
Fixes issue #60.
Pretty minor--I've deferred more thoroughgoing revisions to any components until after we've got tests lined up for them. I did add in-file-global variables to track the maximum number of items for the different categories of display grid, which were currently appearing as raw constants in several different locations.
Tested locally to confirm the layout looks as expected. During testing, I realized that the variable-selection-truncation notice for the 2D Matrix view was not being displayed. Turns out it is actually on the page, just the CSS for the matrix grid winds up covering it up. Fully diagnosing that and fixing it at the root would probably involve tweaks to several different components, which I'm not prepared to do at this point, so I just added a
divfor this specific case that has a bit more padding so the notice isn't obscured.