Separate acf, histogram tabs

jsoules commented 1 year ago

Fixes #63.

This PR addresses that issue by creating two new tabs in the run-page for plots of histograms and autocorrelation function outputs (respectively). That part is pretty straightforward cut-and-paste code movement, however, I did several rounds of subsequent refactoring to fix the resulting redundant code and to break out reused pieces into (hopefully) more obvious locations. More can still be done in that regard, but I think I got the worst of it managed.

In the process, I removed the "display [variable graphs | acfs | histograms]" checkboxes from the diagnostics tab and the two new tabs, since each of those now show only one type of data. I left a lot of that plumbing in place so that it can be adapted to a checkbox that will control whether the warmup draws are included in the displayed data (see issue #62).

I also did a little light housecleaning by adding a directory for tabs (as distinct from other components).

jsoules commented 1 year ago

Oh, deployed these changes to dev preview at https://flatironinstitute.github.io/mcmc-monitor/dev/?s=https://lit-bayou-76056.herokuapp.com#/run/multi-normal-1

codecov-commenter commented 1 year ago

Codecov Report

Merging #65 (fc70d42) into main (3b2839f) will decrease coverage by 0.33%. The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #65      +/-   ##
========================================
- Coverage   7.40%   7.07%   -0.33%     
========================================
  Files         63      72       +9     
  Lines       5400    5651     +251     
  Branches      78      78              
========================================
  Hits         400     400              
- Misses      5000    5251     +251

Flag	Coverage Δ
gui_units	`8.72% <0.00%> (-0.56%)`	:arrow_down:
svc_units	`2.28% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/CollapsibleElement.tsx	`0.00% <0.00%> (ø)`
src/pages/RunPage.tsx	`0.00% <0.00%> (ø)`
src/tabs/AutoCorrelationTab.tsx	`0.00% <0.00%> (ø)`
src/tabs/ConnectionTab.tsx	`0.00% <0.00%> (ø)`
src/tabs/DiagnosticsTab.tsx	`0.00% <0.00%> (ø)`
src/tabs/DiagnosticsTabFrame.tsx	`0.00% <0.00%> (ø)`
src/tabs/ExportTab.tsx	`0.00% <ø> (ø)`
src/tabs/HistogramTab.tsx	`0.00% <0.00%> (ø)`
src/tabs/RunInfoTab.tsx	`0.00% <ø> (ø)`
src/tabs/ScatterplotsTab.tsx	`0.00% <0.00%> (ø)`
... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

magland commented 1 year ago

I think it looks good. Fine by me to merge as is. I do wonder whether the "Diagnostics" tab should be renamed.

jsoules commented 1 year ago

I do wonder whether the "Diagnostics" tab should be renamed.

Yeah, I was wondering about that... wasn't sure what to call it though. At this point it's variable plots; but "Plots" doesn't seem like a very compelling name...

magland commented 1 year ago

Maybe "Timeseries"

jsoules commented 1 year ago

Updated to Time Series.

magland commented 1 year ago

I'd say this is ready to be deployed... I have some more examples I'd like to share, but I'll wait for these latest updates to be incorporated into prod.

jsoules commented 1 year ago

Just merged and pushed this, so it's now live. (Or, will be in a couple minutes when github-pages updates.)

jsoules commented 1 year ago

Okay, something choked the first time, but I just redeployed and can confirm the new tab layout is now live. Enjoy!

flatironinstitute / mcmc-monitor

Separate acf, histogram tabs #65

Codecov Report