search

flatironinstitute / mcmc-monitor

Monitor MCMC runs in the browser
Other
35 stars 0 forks source link

hard-code webrtc=0 for now #68

Closed magland closed 1 year ago

magland commented 1 year ago

For now, let's hard-code webrtc=0 until we get the fallback-to-http in place. That way, people shouldn't ever get a dead page.

codecov-commenter commented 1 year ago

Codecov Report

Merging #68 (92e5b91) into main (16c6099) will increase coverage by 0.48%. The diff coverage is 62.92%.

@@           Coverage Diff            @@
##            main     #68      +/-   ##
========================================
+ Coverage   5.64%   6.12%   +0.48%     
========================================
  Files         60      82      +22     
  Lines       5385    6527    +1142     
  Branches      21      78      +57     
========================================
+ Hits         304     400      +96     
- Misses      5081    6127    +1046
Flag Coverage Δ
gui_units 7.22% <69.70%> (+0.36%) :arrow_up:
svc_units 2.27% <0.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service/src/logic/OutputManager.ts 0.00% <0.00%> (ø)
service/src/networking/Server.ts 0.00% <0.00%> (ø)
service/src/types/Typeguards.ts 0.00% <0.00%> (ø)
...c/MCMCMonitorDataManager/MCMCMonitorDataManager.ts 0.00% <0.00%> (ø)
...rc/MCMCMonitorDataManager/MCMCMonitorTypeguards.ts 0.00% <0.00%> (ø)
src/MCMCMonitorDataManager/updateChains.ts 0.00% <0.00%> (ø)
src/MCMCMonitorDataManager/updateSequenceStats.ts 0.00% <0.00%> (ø)
src/MCMCMonitorDataManager/updateVariableStats.ts 0.00% <0.00%> (ø)
src/MCMCMonitorDataManager/useMCMCMonitor.ts 0.00% <0.00%> (ø)
src/MCMCMonitorDataManager/MCMCMonitorData.ts 100.00% <100.00%> (+37.46%) :arrow_up:
... and 2 more

... and 22 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jsoules commented 1 year ago

Built off wrong branch--we just did a separate PR