Closed jsoules closed 1 year ago
Merging #94 (848fc40) into main (ef52102) will decrease coverage by
0.14%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 16.15% 16.02% -0.14%
==========================================
Files 80 80
Lines 5854 5905 +51
Branches 138 138
==========================================
Hits 946 946
- Misses 4908 4959 +51
Flag | Coverage Δ | |
---|---|---|
gui_units | 20.48% <0.00%> (-0.24%) |
:arrow_down: |
svc_units | 2.27% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/tabs/ScatterplotsTab.tsx | 0.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@jsoules When you have a chance could you deploy this to dev folder so I can see it in action? Or if you are confident it is not breaking anything, you can go ahead and merge (the code looks fine to me).
When you have a chance could you deploy this to dev folder so I can see it in action?
Sure thing! I've deployed and it should be up as soon as github-pages refreshes.
Looks great!
Sounds good! I'll get that merged & published.
Fix #91.
Adds an info icon which, when clicked, pops up a small text explaining what the scatterplot options mean.
Originally I was going to use a direct tooltip, but the
react-tooltip
module seemed a little finicky. In particular, the tooltip was always getting hidden by the graphs if any graphs were displayed (regardless of what I did with the z-index).