flatironinstitute / mountainlab-js

MountainLab is data processing, sharing and visualization software for scientists. It is built around MountainSort, spike sorting software, but is designed to be more generally applicable.
Other
43 stars 30 forks source link

Allow multiple output file names to be collected into array. #47

Open alexmorley opened 6 years ago

alexmorley commented 6 years ago

At the moment --inputs input:file1 input:file2 is allowed but --outputs output:file1 output:file2 isn't.

Ideally they would both be allowed as it can be useful to have an array of output file names collected automatically as well. @magland was this deliberate?

alexmorley commented 6 years ago

relevant functions are in mlproc/run_process.js: check_inputs_and_substitute_prvs # already works check_outputs_and_substitute_prvs # to update make_temporary_outputs # to update

magland commented 6 years ago

@alexmorley I just hadn't encountered a situation where this was needed. I agree, it would be good to have this capability. This change/enhancement would need to be propagated to the various components (ml-js, lari, mlclient, mountainlab_pytools, ...)

alexmorley commented 6 years ago

OK, I needed it so I have implemented it in mlproc (on my own fork of ml-js) but not got round to propagating through yet.

magland commented 6 years ago

Do u have a pull request for it?

alexmorley commented 6 years ago

Not yet. Soon!