More info about identifiability constraints

flatironinstitute / nemos

NEural MOdelS, a statistical modeling framework for neuroscience.

https://nemos.readthedocs.io/

MIT License

68 stars 7 forks source link

Open billbrod opened 1 month ago

billbrod commented 1 month ago

I think we need a little more info about the identifiability constraints flag on the basis objects:

we definitely need more of an explanation of when and why it should be used. maybe that's in a docs page, maybe we just expand upon it in a docstring
Can it be abstracted so we're no repeating of the code in every basis class? worried about forgetting it.

billbrod commented 1 month ago

Also, I think the hidden attribute should be self._identifiability_constraints, rather than self._ident_constraints