search

flatironinstitute / neurosift

Browser-based NWB visualization and DANDI exploration
Apache License 2.0
41 stars 5 forks source link

"Zoom in" message too restrictive #109

Open bendichter opened 11 months ago

bendichter commented 11 months ago

Sometimes when I am viewing data I am told by neurosift to zoom in, even when I am not viewing that much time. I think a reasonable amount of time to view for ECoG for example would be 10 seconds, but with 30 visible channels I can only view about 0.1 seconds. This is particularly frustrating when I am viewing data that is locally on my computer using the view-nwb command, where data access is fast and neurosift should be able to handle more data at once.

requested by @libertyh

magland commented 11 months ago

@libertyh

Setting the defaults for this is a balancing act. The current settings were established based on remote loading pattern, which I can see is sub-optimal when loading a file from the local machine. It's difficult to test the local situation since I don't have the same file on my computer. Do you have a DANDI example (together with the desired view duration window) I can use for testing?

bendichter commented 11 months ago

@magland how difficult would it be to have a setting for maximum dataset size to view within the app that can be adjusted by the user?

libertyh commented 11 months ago

@libertyh

Setting the defaults for this is a balancing act. The current settings were established based on remote loading pattern, which I can see is sub-optimal when loading a file from the local machine. It's difficult to test the local situation since I don't have the same file on my computer. Do you have a DANDI example (together with the desired view duration window) I can use for testing?

@magland Sure! I was trying out this ECoG dataset, since it's most similar to what I'm thinking of converting to NWB. https://dandiarchive.org/dandiset/000019/0.220126.2148 . The zooming is the same both on my local machine running neurosift and when using neurosift and connecting directly from the DANDI archive.

I think for most ECoG/intracranial data/EEG you'd want to be able to load at least 10 seconds at a time to scroll through it, and you'd want to look at multiple channels at once (I often look at up to 64 at a time when preprocessing). I agree with Ben about specifying a maximum dataset size for viewing -- especially if it's local, this shouldn't be too much of a problem. Thanks!

magland commented 11 months ago

@libertyh

Okay, this is what I have done for now. First, I have reduced the default restriction (hopefully this won't cause problems). Second, if you want to override the restriction and view the data at the current zoom level, use Shift+O (for override). This is now included in the help instructions for the timeseries view (question mark button).

Let me know how that works.

CodyCBakerPhD commented 6 months ago

Better default values per neurodata type is no doubt useful, but I also believe #120 could allow the user to select the timescale they want to view (assuming initial render is fast enough) and would help with this more generally