flatironinstitute / neurosift

Browser-based NWB visualization and DANDI exploration
Apache License 2.0
45 stars 6 forks source link

Issue: EphysSummary does not work on data from NeuroConv #191

Closed tabedzki closed 3 months ago

tabedzki commented 4 months ago

Using Neuroconv, I've converted a SpikeGLX folder into a NWB folder. When using the NeuroSift tool through the NWB Guide I am unable to view the electrical series through the summary view plugins.

Screenshot 2024-07-16 at 9 19 58 AM

Screenshot 2024-07-16 at 9 20 23 AM

magland commented 4 months ago

@tabedzki The EphysSummary links are not supposed to be showing up when using NS within GUIDE. That's because Dendro-dependent views require that the data be on DANDI. Can you confirm... is this being viewed from within GUIDE? Or are these datasets on DANDI?

magland commented 4 months ago

@CodyCBakerPhD @garrettmflynn could you confirm which host NWB files are being served on for the neurosift embedded in GUIDE? Is it http://localhost:[port]? If so I'm surprised that the EphysSummary buttons are showing up. NS tries to detect whether the NWB file is being served locally.

CodyCBakerPhD commented 4 months ago

The URL contained in the iframe is https://flatironinstitute.github.io/neurosift/?p=/nwb&url=${this.url} (from https://github.com/NeurodataWithoutBorders/nwb-guide/blob/main/src/electron/frontend/core/components/Neurosift.js#L89)

The GET and POST methods on the local Flask server are defined here: https://github.com/NeurodataWithoutBorders/nwb-guide/blob/main/src/pyflask/namespaces/neurosift.py#L42

which use a base URL of http://127.0.0.1:${port} (from https://github.com/NeurodataWithoutBorders/nwb-guide/blob/2da6359136e2b622c9b763fc816d528c12c06234/src/electron/frontend/core/server/globals.ts#L11)

tabedzki commented 4 months ago

@magland I am using the NWB Guide locally and have not uploaded any data to DANDI for use with NeuroSift.

magland commented 4 months ago

Thanks @CodyCBakerPhD for that information.

@tabedzki Could you please try now? In GUIDE the EphysSummary links are not expected to show up because Dendro views are not supported unless the data are on a remote server. (We could explore the possibility of enabling them locally as well, but that will require some thought).

tabedzki commented 4 months ago

@magland I can confirm that the EphysSummary does not appear now when using a locally provided file.

Screenshot 2024-07-19 at 1 03 39 PM

tabedzki commented 3 months ago

@magland since it no longer shows locally, should we close this issue?