flatironinstitute / nifty-ls

A fast Lomb-Scargle periodogram. It's nifty, and uses a NUFFT!
Apache License 2.0
33 stars 2 forks source link

Adding MacOS support #7

Closed lgarrison closed 4 months ago

lgarrison commented 4 months ago

Working on building wheels for MacOS. The compiled extensions now build with brew install libomp, but segfault during the tests.

lgarrison commented 4 months ago

After 52 commits worth of attempts, I'm giving up on getting OpenMP working on MacOS ARM for now. The problem appears to be some sort of incompatibility with OpenMP in the finufft wheels and OpenMP in nifty-ls. Part of the challenge is that the finufft wheels are currently cross-compiled from x86 to arm; maybe it will be easier to get working if/when they're natively compiled.

Similarly, if we decided to vendor finufft instead of specifying it as a dependency, I bet we could get it working.

Since OpenMP in finufft itself is still working as best as I can tell, the loss of not having OpenMP for the compiled extensions is small.