Kilosort(2) firings.mda dtype increase

flatironinstitute / spikeforest_old

SpikeForest -- spike sorting analysis for website

Apache License 2.0

16 stars 7 forks source link

Open alexmorley opened 5 years ago

alexmorley commented 5 years ago

Without this loss of precision will lead to weird (and silent) bugs for longer recordings.

We could set the dtype dynamically but I don't think the firings.mda size is a big constraint.

alexmorley commented 5 years ago

@magland if this passes the tests I think we should merge straight away unless you can forsee any issues?

magland commented 5 years ago

@jamesjun , could you take a careful look at this PR? I know you've been working a lot with data types recently.