flatironinstitute / stan-playground

Run Stan models in the browser
Apache License 2.0
3 stars 1 forks source link

Integrate analysis.py/analysis.R into UI #119

Open WardBrian opened 3 days ago

WardBrian commented 3 days ago

Compliment of #104

My proposal is something like this:

proposal

magland commented 3 days ago

Could you clarify some more.

Tab 1 would be main.stan, data.json, sampling opts, sampling run button, and sampling outputs?

Tab 2 would be analysis.py and analysis.r which has the sampling outputs available as input?

What about data generation, data.py / data.r?

WardBrian commented 3 days ago

Sorry, that image is of only the right panel. So main.stan/data.json are to the left of this image offscreen

The sampling options/run button are at the top of the panel, and tab 1 is just the summary, traceplots, histograms we have now

magland commented 3 days ago

Okay so the left panel is always just main.stan and data.json?

Where is the data.py/data.r?

In your "plot outputs" that is just the outputs of analysis.py/.r, correct?

Two columns in the right panel seems like a lot. I wonder if the analysis/code should be a tab that covers up the main.stan and data.json, to have more horizontal space.

WardBrian commented 3 days ago

I'm assuming data.py/data.r either live entirely in the left column, or they cover up this panel in a fly-in/fly-out style.

I think keeping at least the model in view at all times is useful.

Correct, it is the plots from R/Python. The second column can (should?) probably just wrap to be below the stdout/stderr on smaller screens. I think that wouldn't be too hard with MaterialUI's Grid, since it has reactive CSS by default

magland commented 3 days ago

I can take a crack at the second analysis/code tab tomorrow, unless someone else wants to.