search

flatironinstitute / stan-playground

Run Stan models in the browser
Apache License 2.0
36 stars 1 forks source link

Replace fi-sci modal with direct use of MUI component. #178

Closed jsoules closed 3 months ago

jsoules commented 3 months ago

This PR removes the dependency on @fi-sci/modal-window in favor of modal dialog boxes more in line with the MUI standard & default look-and-feel. Functionality is unchanged.

Additional changes include moving the content of the connection-configuration modal dialog to its own file, and adding a ThemeProvider component at the project root to fix a persistent known issue in MUI/Vite combinations (see https://github.com/mui/material-ui/issues/31835). (I incidentally updated the versions of MUI and Icons-Material while attempting to address this bug, but I think this isn't super important--we can back out if desired.)

The "CloseableDialog" component follows directly on the example from https://mui.com/material-ui/react-dialog/ (see "Customization").

magland commented 3 months ago

This looks great! Once this gets merged (hopefully soon!). I will resolve conflicts with my 2 outstanding PRs.