flatironinstitute / stan-playground

Run Stan models in the browser
Apache License 2.0
36 stars 1 forks source link

Label case where data is from a prior version of generator script. #237

Closed jsoules closed 3 weeks ago

jsoules commented 3 weeks ago

@WardBrian's earlier PR is a great idea, but I realized there was a risk of miscommunication with the user in the case where the data in data.json came from a data generation script that had subsequently been modified.

This PR expands on that one by adding data source states & logic to label this case.

WardBrian commented 3 weeks ago

I do think it is good to update when the scripts themselves change, but I do wonder if it's worth actually saying "a prior version of", or if just removing the label in this case would be just as good?

jsoules commented 3 weeks ago

Well, being explicit helps set the expectations a little more precisely. But I don't have a super strong feeling about it.