fix env_edit_utils - creates small envs - Githubissues

flatland-association / flatland-rl

The Flatland Framework is a multi-purpose environment to tackle problems around resilient resource allocation under uncertainty. It is designed to be a flexible and method agnostic to solve a wide range of problems in the field of operations research and reinforcement learning.

https://www.flatland-association.org/

MIT License

20 stars 7 forks source link

fix env_edit_utils - creates small envs #36

Closed hagrid67 closed 11 months ago

hagrid67 commented 11 months ago

Objectives

get env_edit_utils working so that small test envs can be created
write some simple tests calling env_edit_utils

Wider objective:

use the env_edit_utils::makeTestEnv to create some minimal railenvs to illustrate the graph representation; currently in use in simple-graph-plot-2022.ipynb

Todos

What needs to be done for the issue to be done and the objectives to be reached:

Turns out this was provoked by (my) changes in transition_map::set_transition which introduced an over-zealous type check for int when bool is also admissible. So I've changed the check to look for np.ndarray and used value.ravel()[0] to extract the element value, which works whether the value is a zero-d or 1-d array. (ie np.array(1) or np.array([1]) both work)

Minimal testing requirements

What functionality shall be covered by a test (qualitatively describe each test):

call makeTestEnv to create a small environment
simple checks to ensure it's a well formed environment?

hagrid67 commented 11 months ago

created branch 36_env_edit_utils (although so far I haven't had to touch env_edit_utils.py)

hagrid67 commented 11 months ago

Closing this now that Martin Buerki @tinubuerki has kindly approved the pull request. (I forgot to add this issue to the PR for automatic closing)