update pyglet to latest

aiAdrian commented 10 months ago

Changes

pyglet version 1.3.2 doesn't no longer supported with python 3.8< under windows.

Related issues

Link to every issue from the issue tracker (if any) you addressed in this PR.

Checklist

[x] Tests are included for relevant behavior changes.
[x] Documentation is added in the docs folder for relevant behavior changes. If you made important user-facing changes, describe them under the [Unreleased] tag in CHANGELOG.md.
[x] New package dependencies are declared in the pyproject.toml file. Requirement files have been updated by running tox -e requirements.
[x] Code works with all supported Python versions (3.8, 3.9 and 3.10). Checks run with all three version and are required to run successfully.
[ ] Code is formatted according to PEP 8 (an IDE like PyCharm can do this for you).
[x] Technical guidelines listed in CONTRIBUTING.md are followed.

aiAdrian commented 10 months ago

tested: windows with python 3.8 linux with python 3.8

----------------- ok

pyglet 2.0.9

fnberta commented 10 months ago

While this might resolve the issue, I would not recommend this approach. The idea of requirements.txt is that it pins exact versions, so that everyone gets exactly the same packages. Moreover, these files are generated from pyproject.toml and should not be edited by hand because the generation step includes the latest version that match the constraints specified in pyproject.toml. Currently, we have a constraint of gym=0.14.0 in there which is the reason pyglet gets installed with such a low version.

Please see my comments in https://github.com/flatland-association/flatland-rl/issues/53 and https://github.com/flatland-association/flatland-rl/pull/55. The easiest "proper" solution would be to get rid of gym which apparently is something we want to do anyway (https://github.com/flatland-association/flatland-rl/issues/26).

aiAdrian commented 10 months ago

Oh. I don't know that the pyproject.toml file is the master. Thus we can delete this PR and Branch as well?

fnberta commented 10 months ago

Yes, I think we can close it especially since you now implemented https://github.com/flatland-association/flatland-rl/pull/56!

flatland-association / flatland-rl