flatmax / gtkiostream

Trivialised Threading, GTK GUIs, Signal Processing, Neural Networks, Audio Processing, Octave interfacing ... and more !
13 stars 7 forks source link

Fixes collision/prototype change with octave 5.x #8

Closed HinTak closed 4 years ago

HinTak commented 4 years ago

"octave_value get_global_value ()" is declared in Octave headers, there is no need to repeat it as extern.

The actual error message is as below:

Octave.C:46:21: error: default argument given for parameter 2 of ‘octave_value get_global_value(const string&, bool)’ [-fpermissive]
   46 | extern octave_value get_global_value (const string& nm, bool silent = false);
      |                     ^~~~~~~~~~~~~~~~
In file included from /usr/include/octave-5.1.0/octave/../octave/hook-fcn.h:33,
                 from /usr/include/octave-5.1.0/octave/../octave/input.h:34,
                 from /usr/include/octave-5.1.0/octave/../octave/lex.h:34,
                 from /usr/include/octave-5.1.0/octave/../octave/parse.h:36,
                 from Octave.C:18:
/usr/include/octave-5.1.0/octave/../octave/variables.h:144:1: note: previous specification in ‘octave_value get_global_value(const string&, bool)’ here
  144 | get_global_value (const std::string& nm, bool silent = false);
      | ^~~~~~~~~~~~~~~~

Fixes https://github.com/flatmax/gtkiostream/issues/4

HinTak commented 4 years ago

This series fixes the rest of issues with octave, and also https://github.com/flatmax/gtkiostream/issues/7 . Now it works on fedora.

flatmax commented 4 years ago

Good set of changes.