flatpak / flatpak-builder-tools

Various helper tools for flatpak-builder
197 stars 107 forks source link

[node] NotImplementedError: Git sources in lockfile v2 format are not supported yet #381

Open Ian2020 opened 1 year ago

Ian2020 commented 1 year ago

flatpak-builder version

1.3.3

Linux distribution and version

Fedora 38

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

npm package-lock.json

Source repository URL

No response

Flatpak-builder manifest URL

https://github.com/Ian2020/io.onlykey.OnlyKey-App/blob/main/io.onlykey.OnlyKey-App.yaml

Description

As title and as intended at the moment the node tool does not support git sources for lockfile v2.

For example fragment of a lockfile below, the nw dependency causes the issue:

{
  "name": "OnlyKey",
  "version": "5.5.0",
  "lockfileVersion": 3,
  "requires": true,
  "packages": {
    "": {
      "name": "OnlyKey",
      "version": "5.5.0",
      "license": "Apache-2.0",
      "dependencies": {
        "auto-launch": "^5.0.5",
        "js-sha256": "^0.9.0",
        "nw": "git+https://git@github.com/Ian2020/npm-installer.git#8e1575a4abf16901924a6146835334ddeaa17b14",
        "nw-autoupdater": "^1.1.11",
        "request": "^2.88.2",
        "sshpk": "^1.17.0"
      },
      "devDependencies": {
        "chai": "^4.3.7",
        "chai-as-promised": "^7.1.1",
        "eslint": "^8.33.0",
        "fs-jetpack": "^5.1.0",
        "gulp": "^4.0.2",
        "gulp-sourcemaps": "^3.0.0",
        "json": "^11.0.0",
        "mocha": "^10.2.0",
        "nw-dev": "^3.0.1",
        "q": "^1.5.1",
        "selenium-webdriver": "^4.8.0",
        "tree-kill": "^1.2.2",
        "yargs": "^17.6.2"
      },
      "optionalDependencies": {
        "appdmg": "^0.6.4"
      }
    },
   ...
jwillikers commented 1 year ago

I need this as well to update the Stretchly Flatpak to the latest version.