flatpak / flatpak-builder

Tool to build flatpaks from source
GNU Lesser General Public License v2.1
139 stars 91 forks source link

GError set over the top of a previous GError or uninitialized memory #296

Open bochecha opened 5 years ago

bochecha commented 5 years ago

Linux distribution and version

Whatever is installed on the Flathub builder as of July 31 2019.

Flatpak-builder version

Whatever is installed on the Flathub builder as of July 31 2019.

Flatpak version

Whatever is installed on the Flathub builder as of July 31 2019.

Description of the problem

My build failed downloading the sources, because there was no space left on the disk.

However, I got the following message which makes me think that triggered a bug:

(flatpak-builder:6088): GLib-WARNING **: 12:00:25.448: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: Failed writing body (4415 != 16384)
Failed to download sources: module blender: Error writing to file: No space left on device

At least the error message says it's a bug in someone's code.

mwleeds commented 5 years ago

The error message being overwritten seems to be here: https://sources.debian.org/src/criticalmass/1:1.0.0-6/curl/lib/sendf.c/?hl=299#L299

sonnyp commented 3 years ago

I was bit by this on buildbot flathub stdio.txt

https://flathub.org/builds/#/builders/27/builds/54317