search

flatpak / flatpak-builder

Tool to build flatpaks from source
GNU Lesser General Public License v2.1
139 stars 93 forks source link

Extension doesn't work with appstraem-compose #368

Open wengxt opened 3 years ago

wengxt commented 3 years ago

Linux distribution and version

Archlinux

Flatpak-builder version

1.0.11

Flatpak version

1.8.3

Description of the problem

appstream-compose doesn't work with extension

Steps to reproduce

Create an extesnion, the prefix will be /app/[some directory]/[Extension name] instead of /app. https://github.com/flatpak/flatpak-builder/blob/a69dbe93b571893c9f1fbbfb5c8b0ae040c8d384/src/builder-manifest.c#L2757 This line hard code it to be /usr or /app, so when you build a extension Error loading AppData file: no file found for [.....] would show up

refi64 commented 3 years ago

I believe extensions generally specify appstream-compose: false anyway...

On Sun, Nov 22, 2020 at 4:10 PM Weng Xuetian notifications@github.com wrote:

Linux distribution and version

Archlinux Flatpak-builder version

1.0.11 Flatpak version

1.8.3 Description of the problem

appstream-compose doesn't work with extension Steps to reproduce

Create an extesnion, the prefix will be /app/[some directory]/[Extension name] instead of /app.

https://github.com/flatpak/flatpak-builder/blob/a69dbe93b571893c9f1fbbfb5c8b0ae040c8d384/src/builder-manifest.c#L2757 This line hard code it to be /usr or /app, so when you build a extension Error loading AppData file: no file found for [.....] would show up

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/flatpak/flatpak-builder/issues/368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM4YSOJGY4BX2KPCQKN5DLSRGD4FANCNFSM4T6YGGJA .

wengxt commented 3 years ago

Here’s a real life example that an extension want to use appstream-compose, but have to manually execute appstream-compose in post-install.

https://github.com/flathub/org.gimp.GIMP.Plugin.Resynthesizer/blob/639782fd175e1bd16b34a2327016d42355eb529e/org.gimp.GIMP.Plugin.Resynthesizer.json#L29

Also, appstream data supports the concept of addons, so I think it totally makes sense that an extension project to use appstream-compose. https://www.freedesktop.org/software/appstream/docs/sect-Quickstart-Addons.html