branch ignored when building a bundled extension - Githubissues

flatpak / flatpak-builder

Tool to build flatpaks from source

GNU Lesser General Public License v2.1

139 stars 93 forks source link

branch ignored when building a bundled extension #388

Closed hfiguiere closed 3 years ago

hfiguiere commented 3 years ago

Linux distribution and version

Fedora 33

Flatpak-builder version

flatpak-builder 1.0.12

Flatpak version

Flatpak 1.10.2

Description of the problem

I'm trying to build a bundled extension from an application. It happens that this extension is a set of audio plugins that can be used by other applications. I set the branch property to 20.08 and it is ignored when generating the extension bundle. See the manifest https://github.com/flathub/org.guitarix.Guitarix/blob/7571ee0e8dc08f698ed831c08bc083920dd3876c/org.guitarix.Guitarix.json

Steps to reproduce

Build https://github.com/flathub/org.guitarix.Guitarix
The resulting bundled extension org.freedesktop.LinuxAudio.Plugins.Guitarix doesn't have the branch 20.08.

Current result is:

$ flatpak install guitarix-origin Guitarix
Looking for matches…
Similar refs found for ‘Guitarix’ in remote ‘guitarix-origin’ (user):

   1) app/org.guitarix.Guitarix/x86_64/master
   2) runtime/org.freedesktop.LinuxAudio.Plugins.Guitarix/x86_64/master

Which do you want to use (0 to abort)? [0-2]:

gasinvein commented 3 years ago

add-extension entries don't have branch property - they have version instead. But the version property doesn't affect exported extension branch, too. Opened #391 to change that.