search

flatpak / flatpak-builder

Tool to build flatpaks from source
GNU Lesser General Public License v2.1
142 stars 93 forks source link

Add a note that app-id is deprecated #572

Closed bbhtt closed 11 months ago

bbhtt commented 11 months ago

This was soft deprecated in https://github.com/flatpak/flatpak-builder/commit/3341fb08adc981879043445e8c40883786705738#diff-fe51491bafa983ec48ccdaa2da758238ee9d5623e20cea285cae410d22dd645dR73, https://github.com/flatpak/flatpak-builder/commit/3341fb08adc981879043445e8c40883786705738#diff-fe51491bafa983ec48ccdaa2da758238ee9d5623e20cea285cae410d22dd645dR359-R365 in favour of "id" which aligns with appstream https://github.com/ximion/appstream/commit/8b412031037ea08028279e9408ea0eda01938c48

This achieves nothing other than putting some doubt and confusion to rest in flathub when people open PRs to switch appid -> id and the docs have no mention of it anywhere.

As far as I can tell, this is the primary source and the only place app-id/id is mentioned in the context of a manifest. There are some other minor examples that need to be switched to id in the flatpak-docs repo. I'll handle that. I didn't see app-id being used in the context of manifest in the flatpak repo.

hfiguiere commented 11 months ago

maybe should start printing a deprecation warning.

hfiguiere commented 11 months ago

Just for fun:

$ grep app-id */*.json |wc -l
66

and this is only the json manifests I have on this machine.