flatpak / flatpak-builder

Tool to build flatpaks from source
GNU Lesser General Public License v2.1
141 stars 93 forks source link

Move locale migration after cleanup #592

Open chrisawi opened 8 months ago

chrisawi commented 8 months ago

Otherwise, module-level cleanup can remove locale symlinks that point to locale data installed by other modules.

Closes #154

I've tested this building an app, and for that at least, it seems to work. I haven't tried building a runtime though. There are two other calls to builder_migrate_locale_dirs() that I haven't really investigated. One happens in init for all runtimes, and the other applies only to platforms.

TingPing commented 8 months ago

If you could, add some tests to https://github.com/flatpak/flatpak-builder/blob/main/tests/test-builder.sh