flatpak / flatpak-builder

Tool to build flatpaks from source
GNU Lesser General Public License v2.1
139 stars 92 forks source link

Inconsistent sha256sum after downloads #607

Closed Pobega closed 4 months ago

Pobega commented 4 months ago

Checklist

flatpak-builder version

1.4.1

Flatpak version

1.15.8

How to reproduce

Build https://github.com/flathub/com.fightcade.Fightcade, see that miniupnpc fails to validate the checksum. After replacing the checksum, it now fails to extract.

Note: the current head of the repo is https://github.com/flathub/com.fightcade.Fightcade/commit/1b05f1fd3d280d5ace617c1114c5c5794d3c80b7

Expected Behavior

The checksum should be valid (verified using wget).

Actual Behavior

The checksum is not valid, and the file does not extract properly with the 'new' checksum.

Additional Information

miniupnpc has been in the build without changing for over a year, so I'm not sure exactly what changed to cause this issue.

Pobega commented 4 months ago

Looks like it may be something with flatpak-builder and that specific mirror. Switching to a different mirror seems to have resolved the issue, at least locally.

I'm keeping this open since the issue is still reproducible and inconsistent with the results seen via a browser download or wget.

TingPing commented 4 months ago

The server they host it on is misconfigured.

> curl -v http://miniupnp.free.fr/files/miniupnpc-2.2.3.tar.gz
... 
< Content-Encoding: x-gzip

You can add the property "disable-http-decompression": true to the source.

Pobega commented 4 months ago

Thank you, I guess that solves the problem here! Appreciate the quick reply.