search

flatpak / flatpak-docs

Flatpak documentation
https://docs.flatpak.org
Other
79 stars 132 forks source link

Installing from repository hosted on GitLab Pages doesn't work due to rate limits #463

Closed ghost closed 4 months ago

ghost commented 4 months ago

The "hosting a repository" section of the docs describes how a repository could be hosted on GitLab Pages. This works fine. But if you try to install anything from such a repository, the installation will fail due to a 429 (Too Many Requests) error.

I only tested this on gitlab.com. If this rate limit can be disabled in a self-hosted GitLab instance, then the docs should probably mention that. If not, then it might be good to remove this entire section to avoid misleading people.

(By the way, the same thing happens if you try to use a GitLab repository directly instead of going through pages.)

bbhtt commented 4 months ago

I host multiple flatpak repos on Gitlab.com https://gitlab.com/projects261/ and never seen a 429. Please talk to Gitlab.com support, my guess is you got rate limited by them somehow - maybe some abuse detection false positive.

bbhtt commented 4 months ago

https://docs.gitlab.com/ee/user/gitlab_com/#gitlabcom-specific-rate-limits

GitLab Pages requests for an IP address 1,000 requests per 50 seconds GitLab Pages requests for a GitLab Pages domain 5,000 requests per 10 seconds GitLab Pages TLS connections for an IP address 1,000 requests per 50 seconds GitLab Pages TLS connections for a GitLab Pages domain 400 requests per 10 seconds

Somehow I doubt it's possible to trip these rate limits, unless you are insanely popular. It's probably something else.

ghost commented 4 months ago

It's probably something else.

Yeah, you're right. I redid everything following the docs more closely this time and it works now.