search

flatpak / flatpak-github-actions

Build your Flatpak application using Github Actions
https://github.com/marketplace/actions/flatpak-builder
MIT License
162 stars 42 forks source link

Fix cache missing #149

Closed xfangfang closed 1 year ago

xfangfang commented 1 year ago

Due to an oversight in actions/toolkit, the CACHE_PATH was modified after running cache.restoreCache function. As a result, an incorrect version was generated during cache upload, leading to cache missing.

This PR independently passes the CACHE_PATH to avoid issues caused by shallow copying.

Fix issue：https://github.com/flatpak/flatpak-github-actions/issues/142

Refer to : https://github.com/actions/toolkit/pull/1378#issuecomment-1478388929

bilelmoussaoui commented 1 year ago

Oh no lol

xfangfang commented 1 year ago

@bilelmoussaoui Now it's ready to merge, Thanks for the help~

xfangfang commented 1 year ago

Rebased to fix conflicts

bilelmoussaoui commented 1 year ago

Would you mind rebasing again please? Thank you

xfangfang commented 1 year ago

Rebased again

bilelmoussaoui commented 1 year ago

Thank you !!!