search

flatpak / flatpak-github-actions

Build your Flatpak application using Github Actions
https://github.com/marketplace/actions/flatpak-builder
MIT License
157 stars 40 forks source link

Switch Docker image to use Flathub's flatpak-builder-lint #171

Open barthalion opened 9 months ago

barthalion commented 9 months ago

This way, all tools match the one used on Flathub infra, and reduce potential breakage caused by Fedora bumping packages.

tytan652 commented 9 months ago

This image switch look like it will breaks CIs (actions consumer) that relies on dnf to install some tools which is a big issue.

Images on Docker Hub should not have such a breakage.

Edit: It can be good base image for Github registry images (#60).

barthalion commented 9 months ago

The fact dnf was available was at best an implementation detail, and not something action users should rely on in the first place.

tytan652 commented 9 months ago

This way, all tools match the one used on Flathub infra, and reduce potential breakage caused by Fedora bumping packages.

Isn't org.flatpak.Builder going to do the same when it will bump flatpak-builder to 1.4 ? Yes, less frequently but it still can happen.

barthalion commented 9 months ago

It's obviously not being bumped to 1.4 until it's actually functional.

bilelmoussaoui commented 9 months ago

Note that I am not a fan of tying the base image with flathub infrastructure and decisions. so please don't merge this until we figure out a way to split the base image provided by the flatpak action and flathub specific bits

barthalion commented 9 months ago

Until this is resolved one way or another, I will be maintaining a soft fork at https://github.com/flathub-infra/flatpak-github-actions/.