flatpak / flatpak-github-actions

Build your Flatpak application using Github Actions
https://github.com/marketplace/actions/flatpak-builder
MIT License
165 stars 45 forks source link

Flathub validations #64

Open GeorgesStavracas opened 3 years ago

GeorgesStavracas commented 3 years ago

Seems like Flathub requires quite a few undocumented extra validation steps:

I'm leaning towards either adding a flathub-validations boolean option to the flat-manager action, or adding a validations string array option. Not sure which one is better.

bilelmoussaoui commented 3 years ago

@GeorgesStavracas I would suggest adding a profile option to flat-manager that will automatically do everything needed for a flathub push. I don't think another profile will exist in the future and it will avoids us having a huge set of options to define and we avoid users not adding some validations to the list and publishing to the repo anyway

razzeee commented 3 years ago

Screenshots need to be mirrored to dl.flathub.org/repo/screenshots (flatpak-builder: Add 'mirror-screenshots-url' input flathub/backend#63)

Can logos be mirrored too? See flathub/website#49

bilelmoussaoui commented 3 years ago

Those apps do so for licensing reasons I believe.

razzeee commented 3 years ago

Not sure I get that, especially if you have a trademark, it shouldn't be problematic.

But we'll have problems with optimizing the pages, that show logos then, as we can't ensure, they're always there/loaded fast.

Malix-Labs commented 2 weeks ago

any change ?