The addition of Email v3 support in 0c2b15c7 caused the automated tests to fail. This was not completely deterministic, because it depended on uninitialized stack contents; for me, it reliably failed on Debian 10 (and on Travis-CI) but passed on Debian testing/unstable.
The important fix here is "xdg-email: Cope gracefully with version being unavailable or wrong type", which could be cherry-picked if there are problems with the rest.
CI: Install a newer version of Ninja for Ubuntu 16.04, too
The latest version of Meson requires a newer version of Ninja than
the one available in Ubuntu 16.04.
Use Ubuntu 18.04 rather than 16.04 for CI
build: Request C99, with GNU extensions
Otherwise inline declarations like "for (int i = 0; ...)" are an error.
xdg-email: Cope gracefully with version being unavailable or wrong type
If we run xdg-email against an old version of xdg-desktop-portal,
getting the version property will raise an error, leaving v NULL
and version undefined (with warnings). Treat that as being version 0.
xdg-email: make version a guint32, not guint
Strictly speaking g_variant_get ("u", .) expects a guint32 , not a
guint , although in any reasonable ABI those are the same.
xdg-email: Fix compilation against older GLib
tests: Fail tests on critical warnings
test-email: Add minimal support for mock Email interface v3
This asserts that we set the "address" parameter if the interface
version is older than 3 or unspecified, or the "addresses" parameter
otherwise. The new features of v3 (multiple addresses, cc and bcc)
are not tested yet.
smcv
commented
4 years ago
The addition of Email v3 support in 0c2b15c7 caused the automated tests to fail. This was not completely deterministic, because it depended on uninitialized stack contents; for me, it reliably failed on Debian 10 (and on Travis-CI) but passed on Debian testing/unstable.
The important fix here is "xdg-email: Cope gracefully with version being unavailable or wrong type", which could be cherry-picked if there are problems with the rest.
CI: Install a newer version of Ninja for Ubuntu 16.04, too
The latest version of Meson requires a newer version of Ninja than the one available in Ubuntu 16.04.
Use Ubuntu 18.04 rather than 16.04 for CI
build: Request C99, with GNU extensions
Otherwise inline declarations like "for (int i = 0; ...)" are an error.
xdg-email: Cope gracefully with version being unavailable or wrong type
If we run xdg-email against an old version of xdg-desktop-portal, getting the version property will raise an error, leaving v NULL and version undefined (with warnings). Treat that as being version 0.
xdg-email: make version a guint32, not guint
Strictly speaking g_variant_get ("u", .) expects a guint32 , not a guint , although in any reasonable ABI those are the same.
xdg-email: Fix compilation against older GLib
tests: Fail tests on critical warnings
test-email: Add minimal support for mock Email interface v3
This asserts that we set the "address" parameter if the interface version is older than 3 or unspecified, or the "addresses" parameter otherwise. The new features of v3 (multiple addresses, cc and bcc) are not tested yet.
test-email: Exercise the --cc and --bcc options