search

flatpak / flatpak.github.io

Flatpak website
55 stars 95 forks source link

feat: add copy button to terminal commands #641

Closed ronanru closed 7 months ago

ronanru commented 8 months ago

This PR adds a copy button to all terminal commands. image

distro.yml file already had a lot of repeating html so instead of adding a button to each command there I added a custom component <terminal-command> that adds a button and a dollar sign before every line on page load.

AsciiWolf commented 7 months ago

Wow, that's great!

@jimmac @barthalion Any chance you could review this PR? Thanks!

barthalion commented 7 months ago

Looks good to me.

jimmac commented 7 months ago

Can't really comment on the code, but in terms of improved experience, it's good.

AsciiWolf commented 7 months ago

@razzeee Is it ok to merge this? I am not sure whether the Flathub setup page is manually copied from the Flatpak.org quick setup page or if there is some automatic script involved.

razzeee commented 7 months ago

Don't worry about the flathub site, it's a manual process right now and I can take care of breakage.

AsciiWolf commented 7 months ago

Thanks! Let's merge this. :-)