flatpak / libportal

libportal - Flatpak portal library
https://libportal.org
GNU Lesser General Public License v3.0
82 stars 40 forks source link

Use of deprecated `gdk_wayland_toplevel_unexport_handle` #148

Closed picsel2 closed 2 months ago

picsel2 commented 7 months ago

Building libportal 0.7.1 with the nightly Gnome Flatpak SDK issues this warning:

[27/34] Compiling C object libportal/libportal-gtk4.so.1.0.0.p/portal-gtk4.c.o
../libportal/portal-gtk4.c: In function ‘_xdp_parent_unexport_gtk’:
../libportal/portal-gtk4.c:81:7: warning: ‘gdk_wayland_toplevel_unexport_handle’ is deprecated: Use 'gdk_wayland_toplevel_drop_exported_handle' instead [-Wdeprecated-declarations]
   81 |       gdk_wayland_toplevel_unexport_handle (GDK_TOPLEVEL (surface));
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-4.0/gdk/wayland/gdkwayland.h:38,
                 from ../libportal/portal-gtk4.c:29:
/usr/include/gtk-4.0/gdk/wayland/gdkwaylandtoplevel.h:56:26: note: declared here
   56 | void                     gdk_wayland_toplevel_unexport_handle (GdkToplevel *toplevel);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Location of the call: https://github.com/flatpak/libportal/blob/main/libportal/portal-gtk4.c#L81

Build Configuration

========================================================================
Building module libportal in /var/home/sebastian/git/gtg/.flatpak-builder/build/libportal-1
========================================================================
The Meson build system
Version: 1.4.0
Source dir: /run/build/libportal
Build dir: /run/build/libportal/_flatpak_build
Build type: native build
Project name: libportal
Project version: 0.7.1
C compiler for the host machine: ccache cc (gcc 13.2.0 "cc (GCC) 13.2.0")
C linker for the host machine: cc ld.bfd 2.42
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports arguments -Wno-unused-parameter: YES 
Compiler for C supports arguments -Wno-missing-field-initializers: YES 
Compiler for C supports arguments -fvisibility=hidden: YES 
Has header "sys/vfs.h" : YES 
Configuring config.h using configuration
Found pkg-config: YES (/usr/bin/pkg-config) 2.2.0
Build-time dependency glib-2.0 found: YES 2.81.0
Program /usr/bin/glib-mkenums found: YES (/usr/bin/glib-mkenums)
Dependency glib-2.0 found: YES 2.81.0 (cached)
Program /usr/bin/glib-mkenums found: YES (/usr/bin/glib-mkenums)
Run-time dependency gio-2.0 found: YES 2.81.0
Run-time dependency gio-unix-2.0 found: YES 2.81.0
Run-time dependency gobject-introspection-1.0 found: YES 1.80.2
Dependency gobject-introspection-1.0 found: YES 1.80.2 (cached)
Program /usr/bin/g-ir-scanner found: YES (/usr/bin/g-ir-scanner)
Dependency gobject-introspection-1.0 found: YES 1.80.2 (cached)
Program /usr/bin/g-ir-compiler found: YES (/usr/bin/g-ir-compiler)
Program vapigen found: YES (/usr/bin/vapigen)
Dependency gtk+-3.0 skipped: feature backend-gtk3 disabled
Run-time dependency gtk4 found: YES 4.15.1
Program vapigen found: YES (/usr/bin/vapigen)
Compiler for language cpp skipped: feature backend-qt5 disabled
Dependency qt5 (modules: Core, Gui, X11Extras, Widgets) skipped: feature backend-qt5 disabled
Build targets in project: 10

libportal 0.7.1

  Backends
    enabled backends: gtk4

  User defined options
    prefix          : /app
    backend-gtk3    : disabled
    backend-gtk4    : enabled
    backend-qt5     : disabled
    docs            : false
    tests           : false
smcv commented 2 months ago

This is fixed in 0.8.1, I think.