search

flatpak / libportal

libportal - Flatpak portal library
https://libportal.org
GNU Lesser General Public License v3.0
80 stars 39 forks source link

New release to make InputCapture and RemoteDesktop session restore available #152

Closed whot closed 2 months ago

whot commented 4 months ago

The last release was around 9 months ago, could we have a new one please? This would make the InputCapture portal support and the xdp_portal_create_remote_desktop_session_full call available. Thanks!

Related input-leap issue

theofficialgman commented 3 months ago

bump

whot commented 2 months ago

bump again

nbolton commented 2 months ago

Bump from the Synergy project too :slightly_smiling_face:

I'd like to second @whot's request:

could we have a new [release] please

Synergy is waiting on a release form libportal so that we can ship Wayland support.

Relevant Synergy discussion: https://github.com/symless/synergy/discussions/7456

Portal input capture works great for us, so I'd say it's ready for release.

@GeorgesStavracas

theofficialgman commented 2 months ago

Portal input capture works great for us, so I'd say it's ready for release.

For what it is worth I have experience multiple instances of mouse/keyboard going fully unresponsive immediately after accepting the input capture portal prompt. I cannot reproduce it at will but it occurs with inputleap on a kde plasma wayland 6.1.4 system using git master libportal on occasion.

nbolton commented 2 months ago

Portal input capture works great for us, so I'd say it's ready for release.

For what it is worth I have experience multiple instances of mouse/keyboard going fully unresponsive immediately after accepting the input capture portal prompt. I cannot reproduce it at will but it occurs with inputleap on a kde plasma wayland 6.1.4 system using git master libportal on occasion.

I believe this should be a bug report in and of itself, even if you don't have exact repro steps.

IMO, this should not prevent the release of portal input capture.

Edit: Hmm, maybe I was being a bit hasty, I have also seen an issue in the latest libportal where nautilus fails to launch. I plan to raise a bug report for this.

theofficialgman commented 2 months ago

I just experienced the issue again today @whot maybe the following logs mean something to you. let me know which application this issue is likely a result of and I will open a dedicated bug report there

Sep 01 14:29:02 garrett-desktop systemd[2303]: Started app-\x2fhome\x2fgarrett\x2finput\x2dleap\x2dubuntu\x2d22\x2d04\x2fbin\x2finput\x2dleap@c9345465f7bc42708df765f5fff41d9b.service - /home/garrett/input-leap-ubuntu-22-04/bin/input-leap.
Sep 01 14:29:03 garrett-desktop input-leap[4642]: *** WARNING *** The program 'input-leap' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
Sep 01 14:29:03 garrett-desktop input-leap[4642]: *** WARNING *** Please fix your application to use the native API of Avahi!
Sep 01 14:29:03 garrett-desktop input-leap[4642]: *** WARNING *** For more information see <http://0pointer.de/blog/projects/avahi-compat.html>
Sep 01 14:29:03 garrett-desktop input-leap[4642]: *** WARNING *** The program 'input-leap' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
Sep 01 14:29:03 garrett-desktop input-leap[4642]: *** WARNING *** Please fix your application to use the native API of Avahi!
Sep 01 14:29:03 garrett-desktop input-leap[4642]: *** WARNING *** For more information see <http://0pointer.de/blog/projects/avahi-compat.html>
Sep 01 14:29:03 garrett-desktop kded6[2661]: Registering ":1.89/StatusNotifierItem" to system tray
Sep 01 14:29:03 garrett-desktop input-leap[4642]: ("-f", "--no-tray", "--debug", "INFO", "--name", "garrett-desktop", "--disable-client-cert-checking", "-c", "/tmp/InputLeap.pNPhmM", "--address", ":24800")
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: registering eis_handshake v1 object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:handshake_version(0)) signature 'u'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.handshake_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports handshake version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.context_type() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.name() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_connection version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_callback version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_pingpong version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_seat version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_device version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_pointer version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_pointer_absolute version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_scroll version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_button version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_keyboard version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.interface_version() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: client 0x1 supports ei_touchscreen version 1
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_handshake.finish() on object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:interface_version(1)) signature 'su'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: registering eis_connection v1 object 0xff00000000000000
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0 (eis_handshake@v1:connection(2)) signature 'unu'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: registering eis_pingpong v1 object 0xff00000000000001
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0xff00000000000000 (eis_connection@v1:ping(3)) signature 'nu'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: deregistering eis_handshake v1 object 0
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: Client dispatch: NEW -> CONNECTING
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: dispatching eis_connection.sync() on object 0xff00000000000000
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: 🪳  libeis bug:  Received invalid version 24 for object id 0x1. Disconnecting
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: Received invalid version 24 for object id 0x1.
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: Client error: Received invalid version 24 for object id 0x1.
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: queuing event type EIS_EVENT_CLIENT_DISCONNECT (2)
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: sending: object 0xff00000000000000 (eis_connection@v1:disconnected(0)) signature 'uus'
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: deregistering eis_connection v1 object 0xff00000000000000
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: deregistering eis_pingpong v1 object 0xff00000000000001
Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: Client dispatch: CONNECTING -> DISCONNECTED
Sep 01 14:29:04 garrett-desktop systemd[1]: systemd-localed.service: Deactivated successfully.
Sep 01 14:29:07 garrett-desktop systemd[1]: systemd-timedated.service: Deactivated successfully.
Sep 01 14:29:17 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Activating input capture, crossing barrier( Qt::Vertical 0 [ 0 , 1439 ]) at QPoint(0,983) with QPointF(-8,0)
Sep 01 14:29:56 garrett-desktop kernel: usb 1-4: USB disconnect, device number 2
Sep 01 14:29:57 garrett-desktop kernel: usb 1-4: new full-speed USB device number 5 using xhci_hcd
Sep 01 14:29:57 garrett-desktop kernel: usb 1-4: New USB device found, idVendor=046d, idProduct=c53f, bcdDevice=44.01
Sep 01 14:29:57 garrett-desktop kernel: usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0
Sep 01 14:29:57 garrett-desktop kernel: usb 1-4: Product: USB Receiver
Sep 01 14:29:57 garrett-desktop kernel: usb 1-4: Manufacturer: Logitech
Sep 01 14:29:57 garrett-desktop kernel: logitech-djreceiver 0003:046D:C53F.0007: hidraw1: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb-0000:00:14.0-4/input0
Sep 01 14:29:57 garrett-desktop kernel: logitech-djreceiver 0003:046D:C53F.0008: hiddev0,hidraw2: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:00:14.0-4/input1
Sep 01 14:29:57 garrett-desktop kernel: logitech-djreceiver 0003:046D:C53F.0009: hiddev1,hidraw4: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:14.0-4/input2
Sep 01 14:29:57 garrett-desktop kernel: logitech-djreceiver 0003:046D:C53F.0009: device of type eQUAD Lightspeed 1.1 (0x0d) connected on slot 1
Sep 01 14:29:57 garrett-desktop mtp-probe[4772]: checking bus 1, device 5: "/sys/devices/pci0000:00/0000:00:14.0/usb1/1-4"
Sep 01 14:29:57 garrett-desktop mtp-probe[4772]: bus: 1, device: 5 was not an MTP device
Sep 01 14:29:57 garrett-desktop kernel: input: Logitech G305 as /devices/pci0000:00/0000:00:14.0/usb1/1-4/1-4:1.2/0003:046D:C53F.0009/0003:046D:4074.000A/input/input34
Sep 01 14:29:57 garrett-desktop kernel: logitech-hidpp-device 0003:046D:4074.000A: input,hidraw5: USB HID v1.11 Keyboard [Logitech G305] on usb-0000:00:14.0-4/input2:1
Sep 01 14:29:57 garrett-desktop kernel: logitech-hidpp-device 0003:046D:4074.000A: HID++ 4.2 device connected.
Sep 01 14:29:57 garrett-desktop mtp-probe[4783]: checking bus 1, device 5: "/sys/devices/pci0000:00/0000:00:14.0/usb1/1-4"
Sep 01 14:29:57 garrett-desktop mtp-probe[4783]: bus: 1, device: 5 was not an MTP device
Sep 01 14:29:57 garrett-desktop systemd-logind[877]: Watching system buttons on /dev/input/event5 (Logitech G305)
whot commented 2 months ago

I cannot reproduce it at will but it occurs with inputleap on a kde plasma wayland 6.1.4 system using git master libportal on occasion.

libportal is used client-side only by input-leap. If your devices go unresponsive that means it's something compositor side (i.e. kwin in your setup).

Sep 01 14:29:04 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Libeis: 🪳 libeis bug: Received invalid version 24 for object id 0x1. Disconnecting

everything is currently on version 1 so if there's a 24 in there somewhere that indicates a compositor bug or a libeis parsing issue. This is during the initial libei connection setup too so well before any actual capture trigger should happen. So even if there's a bug in libei for this, kwin should realize that the connection failed an dit got disconnected.

Sep 01 14:29:17 garrett-desktop kwin_wayland[2421]: kwin_inputcapture: Activating input capture, crossing barrier( Qt::Vertical 0 [ 0 , 1439 ]) at QPoint(0,983) with QPointF(-8,0)

the libei connection failed but then later the input capture barrier is activated nonetheless. Which likely results in your input devices getting sent to a libei client that no longer exists - that would look your devices are freezing up.

So, definitely a kwin bug with a possible libei(s) bug. Does not look like a libportal bug though.

theofficialgman commented 2 months ago

@whot than you for the likely diagnosis. I have created a bug report at kwin as appropriate. Feel free to subscribe or not to it here https://bugs.kde.org/show_bug.cgi?id=492516

GeorgesStavracas commented 2 months ago

Release 0.8.0 is out: https://github.com/flatpak/libportal/releases/tag/0.8.0

GeorgesStavracas commented 2 months ago

If the other issue discussed here turns out to be a libportal issue, please file it separatedly so we can coordinate a 0.8.1 release with the fix.

nbolton commented 2 months ago

Release 0.8.0 is out

Thank you so much!

Looking forward to libpotal 0.8.0 making its way into distros so we can launch Synergy v1.16 Community Edition :slightly_smiling_face:

GeorgesStavracas commented 2 months ago

Thank you for your patience. I appreciate this release took too long to roll out, my time is very limited these days and there aren't many others doing releases. It's a bit of a situation but things are slowly falling in place :)