search

flatpak / libportal

libportal - Flatpak portal library
https://libportal.org
GNU Lesser General Public License v3.0
82 stars 40 forks source link

XdpPortal:update-progress never called on update #37

Closed chergert closed 2 years ago

chergert commented 3 years ago

When using the update portal, it is expected that "update-progress" signal is emitted occasionally with status. I don't seem to be getting any calls there during the update which makes progress state look a bit weird in Builder.

grulja commented 2 years ago

Took me a while to setup a test app to verify this, but it works for me. This is my debug output:

Update started:  true
OnUpdateProgress:  0  status:  0
OnUpdateProgress:  0  status:  0
OnUpdateProgress:  100  status:  0
OnUpdateProgress:  100  status:  2

So the update-progress signal is called. It would be nice to see some steps in between, on the other hand this is exactly mentioned in the documentation:

Gets emitted to indicate progress of the installation. It's undefined exactly how often this is sent, but it will be emitted at least once at the end with non-zero status field. For each successful operation in the update we're also guaranteed to send one (and only one) signal with progress 100.

Given my results I think this bug can be closed.