flatpak / xdg-dbus-proxy

GNU Lesser General Public License v2.1
57 stars 21 forks source link

fix: null point exception #27

Closed hqh2010 closed 2 years ago

hqh2010 commented 2 years ago

debug the command as follows can cause a null pointer exception xdg-dbus-proxy --fd=26 unix:path=/run/usr/1000/bus /run/usr/1000/.dbus-proxy/session-bus-proxy --filter --own=org.gnome.ghex. --talk=ca.desrt.dconf --call=org.freedesktop.portal.= --broadcast=org.freedesktop.portal.=@/org/freedesktop/portal/* in my system, There is no .dbus-proxy folder in the /run/usr/1000/ directory, xdg-dbus-proxy 0.1.1-1 Log:

smcv commented 2 years ago

If flatpak_proxy_start() can return false without setting the error, then that is a bug, which should be fixed. Not printing the error message in this case is just working around that bug.

It looks like a bug that would have caused this was fixed in 30aeffa4 (xdg-dbus-proxy 0.1.2).