Fix segfault when flatpak_proxy_start() fails

flatpak / xdg-dbus-proxy

GNU Lesser General Public License v2.1

57 stars 21 forks source link

Fix segfault when flatpak_proxy_start() fails #8

Closed tofurky closed 5 years ago

tofurky commented 5 years ago

Per the docs on g_socket_listener_add_address(), setting error to NULL causes the parameter to be ignored. If an error occurs in flatpak_proxy_start(), start_proxy() will attempt to print error->message where error is then NULL, causing a segfault.

So, don't set error to NULL.

Signed-off-by: Matt Merhar mattmerhar@protonmail.com

matthiasclasen commented 5 years ago

Yeah, that does not make sense.

tofurky commented 5 years ago

thanks!