flatpak / xdg-desktop-portal-gtk

Gtk implementation of xdg-desktop-portal
GNU Lesser General Public License v2.1
129 stars 102 forks source link

Can't see preview of image because the xdg-desktop-portal-gtk FileChooser thumnail is too small #402

Open mbigras opened 2 years ago

mbigras commented 2 years ago

Hello Flatpak developers,

I'm having an issue previewing images before I attach them to an email. When I attach images to emails, I like to preview the image before to make sure I attach the right one. When I try to preview images on my system—xdg-desktop-portal-gtk triggered by Gmail in Google Chrome on my Debian system running Xfce—the thumnails are so small that I can't see the image—see screenshot.

I am guessing the file choosing dialog is xdg-desktop-portal-gtk because when I run the following command that kills the xdg-desktop-portal-gtk process and the file choosing box disappears.

pgrep -f xdg-desktop-portal-gtk | xargs kill

I think the small thumbnail might be because the thumnail is set to 128 pixels; however, I'm not sure—see the filechooser.c code. https://github.com/flatpak/xdg-desktop-portal-gtk/blob/9702bacc1ae8de2f357974ced2bcd6997dfd4e69/src/filechooser.c#L386

I tried right clicking on the image to open a preview—didn't find a menu item. Also I tried pressing Spacebar to make a preview pop up like macOS Quick Look—that caused the file to attach. I also tried dragging the FileChooser bigger but that didn't work.

Can I make the thumbnails bigger or otherwise preview the images somehow through xdg-desktop-portal-gtk FileChooser?

Thanks for taking a look at this issue and see below for a screenshot and also some terminal output about my system and package versions. Screenshot_2022-11-09_21-52-34_PST

$ dpkg --list google-chrome-stable xdg-desktop-portal-gtk
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                   Version         Architecture Description
+++-======================-===============-============-================================================
ii  google-chrome-stable   107.0.5304.87-1 amd64        The web browser from Google
ii  xdg-desktop-portal-gtk 1.14.0-1        amd64        GTK+/GNOME portal backend for xdg-desktop-portal
$ neofetch
       _,met$$$$$gg.          max@sid 
    ,g$$$$$$$$$$$$$$$P.       ------- 
  ,g$$P"     """Y$$.".        OS: Debian GNU/Linux bookworm/sid x86_64 
 ,$$P'              `$$$.     Host: 23552M8 ThinkPad T430s 
',$$P       ,ggs.     `$$b:   Kernel: 6.0.0-2-amd64 
`d$$'     ,$P"'   .    $$$    Uptime: 55 mins 
 $$P      d$'     ,    $$P    Packages: 1577 (dpkg), 7 (snap) 
 $$:      $$.   -    ,d$$'    Shell: bash 5.2.2 
 $$;      Y$b._   _,d$P'      Resolution: 1760x990 
 Y$$.    `.`"Y$$$$P"'         DE: Xfce 4.16 
 `$$b      "-.__              WM: Xfwm4 
  `Y$$                        WM Theme: Default 
   `Y$$.                      Theme: Xfce [GTK2], Adwaita [GTK3] 
     `$$b.                    Icons: Tango [GTK2], Adwaita [GTK3] 
       `Y$$b.                 Terminal: xfce4-terminal 
          `"Y$b._             Terminal Font: Monospace 11 
              `"""            CPU: Intel i5-3320M (4) @ 3.300GHz 
                              GPU: Intel 3rd Gen Core processor Graphics Controller 
                              Memory: 3216MiB / 7773MiB
TingPing commented 2 years ago

For what you want I think it would take a good bit of UI work but I'm not sure its worth the time investment.

In the medium term this project will switch to GTK4 at some point which has a completely redesigned file chooser that does its own thumbnail view. Its thumbnails are also fairly small but at that point UI improvements would go upstream I imagine.