search

flatpak / xdg-desktop-portal

Desktop integration portal
https://flatpak.github.io/xdg-desktop-portal/
GNU Lesser General Public License v2.1
564 stars 189 forks source link

notifications: Support inline-reply? #485

Open fmuellner opened 4 years ago

fmuellner commented 4 years ago

This is currently under discussion for the org.freedesktop.Notifications spec:

https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/24

I'm sympathetic to the idea, but want to discuss this in the portal context first to not create an incentive for apps to use the underlying freedesktop API over the portal.

In my opinion the worst bit in the proposal is piggybacking the reply on the action, which luckily wouldn't be a problem with the portal API where actions have proper parameters.

So does this look like a worthwhile addition?

TingPing commented 4 years ago

Worth mentioning that xdg-desktop-portal-gtk uses the org.gtk.Notifications interface so it must support this also.

fmuellner commented 4 years ago

But org.gtk.Notifications is a private protocol that is undocumented as far as I can tell, and the proposal doesn't require any changes to the D-Bus API. We only need to agree on a new possible a{sv} entry, and the easiest option is to just use whatever the portal ends up with.

matthiasclasen commented 4 years ago

I think allowing responses is fine.

I admit that the talk of serialization and deserialization in that proposal makes me anticipate the interoperability and robustness issues we're going to see...

ZanderBrown commented 4 years ago

Ideally like org.freedesktop.portal.Notification and org.freedesktop.Application we'd have parameter support in org.freedesktop.Notifications, but we don't

kbroulik commented 4 years ago

Any progress here?

Mikenux commented 1 year ago

There is now a proposal to talk about it: https://github.com/flatpak/xdg-desktop-portal/issues/983