search

flatpak / xdg-desktop-portal

Desktop integration portal
https://flatpak.github.io/xdg-desktop-portal/
GNU Lesser General Public License v2.1
595 stars 192 forks source link

[Secrets] Lock if multiple searches happen at the same time #557

Open bellegarde-c opened 3 years ago

bellegarde-c commented 3 years ago

Look at this https://gitlab.gnome.org/World/lollypop/-/commit/0695ce5eefcf015741a1e35aab25167c129c13ee

I have found a workaround for Eolie and Lollypop but here what is happening. On startup, Lollypop ask Secrets API for two passwords (LAST.FM and LIBRE.FM). Looks like the concurrent lookups do not work for Flatpak (no issue if installed without Flatpak).

Secret.password_search(schema,
                                   SecretAttributes,
                                   Secret.SearchFlags.UNLOCK |
                                   Secret.SearchFlags.LOAD_SECRETS,
                                   None,
                                   self.__on_secret_search)

__on_secret_search() is never called. If i disable LIBRE.FM code, then it works (only one call to Secret.password_search())

bellegarde-c commented 1 year ago

Happening in Geary too: https://gitlab.gnome.org/GNOME/geary/-/merge_requests/835