flatsiedatsie / domoticz-aurora-theme

A modern theme for Domoticz, the open source home automation platform.
GNU General Public License v3.0
35 stars 23 forks source link

Kodi remote popup and rgb popup needs adjustments #13

Open xztraz opened 6 years ago

xztraz commented 6 years ago

Kodi remote control size is a bit small..

image

xztraz commented 6 years ago

RGBW popup. white and brightness sliders in pop-up overlap with text. Maybe this is a base css bug. they'we changed stuff there recently

image

xztraz commented 6 years ago

i think you can just add a non existing kodi in hardware and get the remote popup to test with.

flatsiedatsie commented 6 years ago

Are you on the latest version of the theme? Because the theme no longer tries to interfere with remote control positioning and size.

xztraz commented 6 years ago

Jupp tried now again after updating to latest theme and domoticz as latest. tried in opera(webkit) and firefox.

image

xztraz commented 6 years ago

if turning of center popups it looks like this instead (wider popup but only like one text row high) image

flatsiedatsie commented 6 years ago

Could you try this?

dialog-lmsplayer-remote,

dialog-heosplayer-remote,

dialog-media-remote{

min-height:300px;

}

xztraz commented 6 years ago

same thing. tested in firefox and opera

image

image

fresh git pull of skin

xztraz commented 6 years ago

if i change the min height in inspect element in browser on dialog-media-remote then it gets larger. doesn't the custom css bite?

image

flatsiedatsie commented 6 years ago

try:

dialog-lmsplayer-remote,

dialog-heosplayer-remote,

dialog-media-remote{

min-height:400px!important; padding: 0 20px 0 20px; }

xztraz commented 6 years ago

i found some auto height in a css if uncomented the controls show again but not sure other stuff may brake. ill try the css mods first

xztraz commented 6 years ago

Hah! it works! image

xztraz commented 6 years ago

only thing if having center popup unchecked the control gets bigger and cant fit the box image

flatsiedatsie commented 6 years ago

I cannot create a remote popup here unfortunately. Could you possibly take a screenshot of the html structure (right mouse button ->inspect)?

center_popups.css only has one css item in it:

.ui-dialog, .ui-popup{ height:auto!important; width:auto!important;
position:fixed!important; top:50vh!important; left:50%!important; transform: translate(-50%, -50%)!important; min-height:200px!important; min-width:200px!important; }

So if it affects the remote popup, that would imply that the remote popup also gets the ui-popup class somewhere. If I know how they are relate, I could write an exception in the css to not give a min-width to remotes.

xztraz commented 6 years ago

on todays version of skin with this css added (might be an older cache thou so have that in mind) image

with centered popups image

no centering image

flatsiedatsie commented 6 years ago

OK, so in the second picture, looking at the applied CSS in the right column, I see very little influence of the Aurora theme, and none that could explain the cut-off. Perhaps that's in the "dialog-media-remote" div inside it.

In theory, if you disable the theme's centering option, Domoticz' own methods of positioning should take over. It uses javascript to position and size things. This can be seen at the top of that column, in the 'element-stlyle' part. So unless we find some styling on the "dialog-media-remote" div, could it be that this is just normal Domoticz behaviour?

xztraz commented 6 years ago

oh i might have selected the wrong item for inspect. Before i applied the aurora theme i used the remote quite often and then the scaling and frame was ok. you don't have the possibility to set up a kodi install to try out the remote?

flatsiedatsie commented 6 years ago

I don't have that possibility (I've tried). Domoticz doesn't allow you to fake a remote.

xztraz commented 6 years ago

Ah. how can i help? :) i think the buttons aren't working either when the frame is fudged. i guess an image map that gets upset or something.

flatsiedatsie commented 6 years ago

I suspect the best bet is to try and not interfere with how Domoticz does things. It uses javascript to position and scale things. If you can find the CSS form the theme that 'gets in the way', then we can remove it.

xztraz commented 6 years ago

image this is how it looks in inspect

xztraz commented 6 years ago

i've tried disabling all style rows but to no avail.. but found out that you can add a dummy device.

Add hardware "Kodi Media Server" Push setup and add a dummy device. any ip will do. push add. go to devices page. add kodi device. go to switches. push on button(leftmost button) now you have the remote to play with.

flatsiedatsie commented 5 years ago

@xtraz I tried it again, but that sequence doesn't work for me. clicking the left most button doesn't launch the pop-up.