search

flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Simplify and extend tests for binary operators #140

Closed saraedum closed 4 years ago

saraedum commented 4 years ago

this is a preparation for testing floor division.

We also simplify the generator logic. Making the "iterations" explicit in the generator is not necessary; instead we can just "take" from the generator.

Originally, we needed the iterations to make sure that the number field is still around in renf_elem_generator.hpp to renf_elem_clear the last element generated. Now, we just hold on to a copy of that last number field so we do not have to synchronize lifetimes anymore.

saraedum commented 4 years ago

@videlec any clue why travis does not want to pick this one up?