search

flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Fix bug in fdiv #145

Closed saraedum closed 3 years ago

saraedum commented 3 years ago

arb_radref is not the diameter but the radius. So to single out a unique integer, it must be <½. Note that this is again not caught by the tests because we are not generating enough small numbers.

saraedum commented 3 years ago

I hope you had no objections @videlec

saraedum commented 3 years ago

How many bugs can you hide in these few lines. It still does not work correctly. I think I know where the remaining issue is. Anyway, let me write better tests here. This should never have passed tests if it was that broken.