flatsurf / e-antic

Embedded algebraic number fields
https://flatsurf.github.io/e-antic/libeantic/
GNU Lesser General Public License v3.0
12 stars 11 forks source link

Split renfxx.h #174

Closed saraedum closed 3 years ago

saraedum commented 3 years ago

There were a number of minor issues with renfxx.h:

I sneaked in an ODR violation fix in cppyy.h (now renamed to cppyy.hpp.) A non-template definition in a header file should be marked inline so it can be deduplicated.

saraedum commented 3 years ago

@videlec I had originally meant to put this only on the documentation branch but since I need additional operator= to improve normaliz performance, I don't want to create too many conflicts here. I'll merge this into the documentation branch later.

codecov[bot] commented 3 years ago

Codecov Report

Merging #174 (c2ed29a) into master (f133fee) will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   90.11%   90.21%   +0.09%     
==========================================
  Files         104      105       +1     
  Lines        1953     1952       -1     
==========================================
+ Hits         1760     1761       +1     
+ Misses        193      191       -2     
Impacted Files Coverage Δ
libeantic/e-antic/cereal.hpp 100.00% <ø> (ø)
libeantic/srcxx/renf_elem_class.cpp 90.49% <ø> (ø)
libeantic/e-antic/renf_class.hpp 100.00% <100.00%> (ø)
libeantic/e-antic/renf_elem_class.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f133fee...c2ed29a. Read the comment docs.